diff --git a/proxy/shadowsocks_2022/outbound.go b/proxy/shadowsocks_2022/outbound.go index 67e0acd28..c7ee1e279 100644 --- a/proxy/shadowsocks_2022/outbound.go +++ b/proxy/shadowsocks_2022/outbound.go @@ -169,8 +169,8 @@ func (o *Outbound) Process(ctx context.Context, link *transport.Link, dialer int return buf.Copy(responseReader, link.Writer, buf.UpdateActivity(timer)) } - responseDoneAndCloseWriter := task.OnSuccess(responseDone, task.Close(link.Writer)) - if err := task.Run(ctx, requestDone, responseDoneAndCloseWriter); err != nil { + responseDonePost := task.OnSuccess(responseDone, task.Close(link.Writer)) + if err := task.Run(ctx, requestDone, responseDonePost); err != nil { return errors.New("connection ends").Base(err) } @@ -212,8 +212,8 @@ func (o *Outbound) Process(ctx context.Context, link *transport.Link, dialer int return nil } - responseDoneAndCloseWriter := task.OnSuccess(responseDone, task.Close(link.Writer)) - if err := task.Run(ctx, requestDone, responseDoneAndCloseWriter); err != nil { + responseDonePost := task.OnSuccess(responseDone, task.Close(link.Writer)) + if err := task.Run(ctx, requestDone, responseDonePost); err != nil { return errors.New("connection ends").Base(err) } diff --git a/proxy/shadowsocks_2022/shadowsocks_2022.go b/proxy/shadowsocks_2022/shadowsocks_2022.go index ec8562e6a..892e6ed49 100644 --- a/proxy/shadowsocks_2022/shadowsocks_2022.go +++ b/proxy/shadowsocks_2022/shadowsocks_2022.go @@ -18,9 +18,7 @@ import ( ) func (s *ServerUDPSession) UpdateConn(conn stat.Connection) { - if s.currentConn.Load() == nil { - s.currentConn.Store(conn) - } + s.currentConn.Store(conn) if s.timer != nil { s.timer.Update() } @@ -70,6 +68,8 @@ func (s *ServerUDPSession) EnsureLink( return link, nil } + s.currentConn.Store(conn) + sessCtx, cancel := context.WithCancel(ctx) inbound := session.InboundFromContext(sessCtx) if inbound != nil && s.User != nil { @@ -94,7 +94,6 @@ func (s *ServerUDPSession) EnsureLink( return nil, err } - s.link.Store(link) sessionPolicy := policyManager.ForLevel(level) s.timer = signal.CancelAfterInactivity(sessCtx, func() { if s.manager != nil { @@ -103,6 +102,7 @@ func (s *ServerUDPSession) EnsureLink( s.Close() cancel() }, sessionPolicy.Timeouts.ConnectionIdle) + s.link.Store(link) go handleUDPResponse(s, link, dest, responseEncoder) return link, nil diff --git a/proxy/shadowsocks_2022/stream.go b/proxy/shadowsocks_2022/stream.go index acde16155..4de3b3605 100644 --- a/proxy/shadowsocks_2022/stream.go +++ b/proxy/shadowsocks_2022/stream.go @@ -11,6 +11,7 @@ import ( "sync" "time" + "github.com/xtls/xray-core/common" "github.com/xtls/xray-core/common/antireplay" "github.com/xtls/xray-core/common/buf" "github.com/xtls/xray-core/common/errors" @@ -629,6 +630,7 @@ func InitServerStream(conn net.Conn, method *CipherMethod, psk, saltSlice []byte func TransportTCP(ctx context.Context, sessionPolicy policy.Session, reader buf.Reader, writer buf.Writer, link *transport.Link) error { ctx, cancel := context.WithCancel(ctx) timer := signal.CancelAfterInactivity(ctx, cancel, sessionPolicy.Timeouts.ConnectionIdle) + defer timer.SetTimeout(0) ctx = policy.ContextWithBufferPolicy(ctx, sessionPolicy.Buffer) requestDone := func() error { @@ -644,6 +646,12 @@ func TransportTCP(ctx context.Context, sessionPolicy policy.Session, reader buf. return buf.Copy(link.Reader, writer, buf.UpdateActivity(timer)) } - responseDoneAndCloseWriter := task.OnSuccess(responseDone, task.Close(link.Writer)) - return task.Run(ctx, requestDone, responseDoneAndCloseWriter) + requestDoneAndCloseWriter := task.OnSuccess(requestDone, task.Close(link.Writer)) + if err := task.Run(ctx, requestDoneAndCloseWriter, responseDone); err != nil { + common.Interrupt(link.Reader) + common.Interrupt(link.Writer) + return errors.New("connection ends").Base(err) + } + + return nil }